fix: remove libonedal_sycl.a from makefile #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
added
the
dependencies
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
requested review from
Alexsandruss,
napetrov,
homksei,
ahuber21 and
ethanglaser
as code owners
Vika-F
reviewed
Nov 12, 2024
Vika-F
reviewed
Nov 12, 2024
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
requested review from
david-cortes-intel,
icfaust,
olegkkruglov and
avolkov-intel
Vika-F
approved these changes
Nov 13, 2024
|
/intelci: run |
|
Latest commit nightly: http://intel-ci.intel.com/efa1be5f-0cb1-f11c-b33b-a4bf010d0e2d |
|
/intelci: run |
|
/intelci: run |
napetrov
reviewed
Nov 14, 2024
| @@ -75,6 +75,8 @@ endif | |||
|
|
|||
| MPI_PATH = $(I_MPI_ROOT) | |||
|
|
|||
| # This file uses an outdated build system that is no longer supported. | |||
There was a problem hiding this comment.
should we just remove this one? not in this PR though. @Alexandr-Solovev @homksei
napetrov
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR introduces removing libonedal_sycl.a library from oneDAL build. Originally it was a copy of libmkl_sycl.a library, but since oneMKL migration we observed an issue with increasing build size. With the current changes MKL_SYCL dependency will be added in static applications through CMake.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing